Show or Hide broadcasts results #16650
Conversation
|
the boards on initial position are superfluous; they add no information, the board grid now only duplicates the games list on the left. The initial position is also wrong in chess960 tournaments. Not sure what to do about it. |
|
the clocks on the game list are hidden by the setting, but not on the boards grid. |
|
I suppose in no-results mode, clicking a board should lead to the initial position, not the current or final position. |
|
The toggle state is not persisted yet |
|
The eval gauges of the current/last position are still visible |
… show-hide-broadcasts-results
|
The clocks are now also hidden in the boards grid. I made the toggle persistent and made the eval gauges invisible if the results toggle is off. I will try soon to make the click on a board take to the initial position when having the results toggle to off. For the boards grid initial positions, I don't really know what we could do, maybe a blur or a "no spoil" image or something like this ? |
ui/analyse/src/study/multiBoard.ts
Outdated
| ) { | ||
| this.playing = toggle(false, this.redraw); | ||
| this.showResults = toggle(true, this.redraw); | ||
| this.showResults = storedBooleanProp("study.showResults", true); |
There was a problem hiding this comment.
this.redraw has been dropped? it wasn't necessary?
There was a problem hiding this comment.
It seems to be working fine without it, I will test it more to make sure it's not needed.
There's no good solution. We could try empty boards with, yeah, some sort of "no spoilers" ribbon or something |
…ts toggle to false
… show-hide-broadcasts-results
|
I tried something for the boards, they are now empty (no pieces) and there is a note before the grid telling the user that the previews are empty to avoid spoils. If this solution is good enough, I think we will just have to make the note translatable. |
ui/analyse/src/study/studyCtrl.ts
Outdated
| const componentCallbacks = () => { | ||
| if (!this.multiBoard.showResults()) | ||
| { | ||
| this.ctrl.userJump(this.ctrl.initialPath) |
There was a problem hiding this comment.
according to my tests, this flashes the current position, before reverting to the initial position.
Resolves #14762
My approach is to add a new toggle like the "playing" or "eval" one. If it is set to true (default value), everything is the same as it is currently. If it is set to false, we :
Let me know if I need to change or add something !