Skip to content

Consistent move style #16627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2024
Merged

Consistent move style #16627

merged 2 commits into from
Dec 21, 2024

Conversation

@dav1312
Copy link
Contributor

@dav1312 dav1312 commented Dec 19, 2024 •
edited
Loading

Make the style of annotated moves consistent with the style of non-annotated moves

This is my first PR to the project, hopefully I didn't make any mistakes :)

Lichess-colors-1-before.mp4
Lichess-colors-1-after.mp4

@ornicar
Copy link
Collaborator

ornicar commented Dec 21, 2024

There seem to be some readability issues, especially here
image

We need to ensure a much higher contrast

@dav1312
Copy link
Contributor Author

dav1312 commented Dec 21, 2024 •
edited
Loading

By mistake (ironic) I used $c-font-clearer instead of $c-over for the text color so the contrast ratio should be similar to the board annotation
image

I am planning on changing the colors of all annotations in the future to make more sense imo

@ornicar
Copy link
Collaborator

ornicar commented Dec 21, 2024

image

image

the mistake :hover background is lighter in the dark theme than it is on the light theme. I think it doesn't make a lot of sense, and it contributes to the low contrast in dark theme.

@dav1312
Copy link
Contributor Author

dav1312 commented Dec 21, 2024

the mistake :hover background is lighter in the dark theme than it is on the light theme.

They have different colors, I'm simply using them, I didn't want to mess with that in this pr.

lila/ui/common/css/theme/_light.scss

Lines 22 to 27 in 77eb003

$c-inaccuracy: hsl(202, 78%, 40%);
$c-mistake: hsl(41, 100%, 35%);
$c-blunder: hsl(0, 68%, 50%);
$c-good: $c-secondary;
$c-brilliant: hsl(129, 71%, 30%);
$c-interesting: hsl(307, 80%, 59%);

lila/ui/common/css/theme/_default.scss

Lines 30 to 35 in 77eb003

$c-inaccuracy: hsl(202, 78%, 62%);
$c-mistake: hsl(41, 100%, 45%);
$c-blunder: hsl(0, 69%, 60%);
$c-good: hsl(88, 62%, 37%);
$c-brilliant: hsl(129, 71%, 45%);
$c-interesting: hsl(307, 80%, 70%);

@ornicar ornicar merged commit cf796c1 into lichess-org:master Dec 21, 2024
3 checks passed
@ornicar
Copy link
Collaborator

ornicar commented Dec 21, 2024

I see. It would be interesting to review these colors and how they work on the 3 site themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dav1312 @ornicar