improve/ruin streamer approval experience #16629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schlawg
commented
Dec 20, 2024
- dont blow away dirty form edits when adding a picture
- put minor (non-url) edits into approval queue while streamer stays listed
- notify on application denial, provide link to /page/streamer-page-activation. if that cms page does not already exist, it should be created before deploying this.
- replace a few confusing, redundant, or inaccurate translations with worse ones
- provide confirm dialog informing the user their listing will be suspended while a change in youtube or twitch details are being processed
- dont require headline in some places and not in others
- add a few status icons and texts to streamer edit page
`initModule(old: { youtube: string; twitch: string })` expects `string`s
but the previous implementation could have `null` and empty strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.