Cross-platform selection prevention in lobby and header #16639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d selecting in certain areas of the homepage.
|
Are you sure they're all necessary? According to MDN only safari needs it |
|
@ornicar That link only shows an example for Safari, but I'm not sure if they explicitly said that's the only browser that needs it (edit: the table says it is for current versions). It's probably the most important one in any case, though I saw the others mentioned in some SO answers, such as this slightly dated one. They're mainly for supporting older browsers - e.g., |
|
You'll find our browser support table here, Edge pre-chromium is not supported. |
…ons, Safari is the only one that needs it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a PC, the user isn't allowed to select certain things from the header and areas of the lobby. This PR extends that to include other platforms, like phones. Now something like the following (screenshot from my iphone) won't be possible: