Skip to content

chess.com domain #16974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

chess.com domain #16974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/relay/src/main/RelayRoundForm.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ object RelayRoundForm:
host <- Option(url.host).map(_.toHostString)
// prevent common mistakes (not for security)
if mode.notProd || !blocklist.exists(subdomain(host, _))
if !subdomain(host, "chess.com") || url.toString.startsWith("https://api.chess.com/pub")
if !subdomain(host, "chess.com") || url.toString.startsWith("https://api.chess.com/pub") || url.toString
.startsWith("https://www.chess.com/events/v1/api")
Copy link
Collaborator

@ornicar ornicar Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about the www. ?

Copy link
Member Author

@SergioGlorias SergioGlorias Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is correct the links we have use www
they don't use without subdomain like lichess

yield url

private def validateUpstreamUrl(s: String)(using Me, Mode): Either[String, URL] = for
Expand Down