Skip to content

Conversation

@johndoknjas
Copy link
Contributor

Two scenarios that this PR fixes:

  • Player A offers a draw, B declines, 20 ply later A is eligible to offer again. However if at that point A goes back a few moves in the notation, the draw button becomes greyed out.
  • Player A goes back a few moves in the notation (say 10 plies back) and offers a draw, which B declines. The players play around 10 plies more, at which point the draw button will be ungrayed for A. Clicking the button has no effect (the backend prevents the draw offer from reaching B), but this still isn't ideal.

…w. This makes it so that clicking back in the notation has no effect on draw offer eligibility.
@johndoknjas johndoknjas force-pushed the use-lastPly-for-draw-offers branch from 5252d1d to ddcd868 Compare February 15, 2025 07:30
@ornicar ornicar merged commit 2969ef3 into lichess-org:master Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants