Copy pgn v3 #17046
Merged
Copy pgn v3 #17046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n one. Also clean up code from past few commits.
… Future (instead of blocking with Await).
…er clicks on the corresponding clipboard button.
ornicar
reviewed
Feb 24, 2025
ui/site/src/domHandlers.ts
Outdated
| setTimeout(() => $(this).attr('data-icon', licon.Clipboard).addClass('button-metal'), 1000); | ||
| }; | ||
| const copyText = (text: string) => navigator.clipboard.writeText(text).then(showCheckmark); | ||
| const call_api = $(this).hasClass('call-api'); |
There was a problem hiding this comment.
our typescript code also uses camelCase, not snake_case.
|
there are some strange things in the commits history of this PR, so I'll do a squash merge to keep the master branch history clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third time's the charm - not sure why I didn't look more into doing it this way before, much simpler.