Skip to content

Fix Missing Learn from Mistakes Next button on Mobile #17052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 12, 2025
Merged

Fix Missing Learn from Mistakes Next button on Mobile #17052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
34cb70d
Bumps grid template row height
ChaseNelson Feb 24, 2025
d704bae
Bump grid row height to max 36vh
ChaseNelson Feb 24, 2025
406a76e
Merge branch 'master' into mobile-learn-from-mistakes
ornicar Feb 25, 2025
4cb8b4f
Merge branch 'master' into mobile-learn-from-mistakes
ChaseNelson Feb 27, 2025
6d92e2d
Moves Next button in Learn from Mistake to row flow for small screens
ChaseNelson Feb 27, 2025
1c4e6dd
Merge branch 'master' into mobile-learn-from-mistakes
ChaseNelson Mar 4, 2025
d7fe92b
Bumps grid template row height to 40vh max
ChaseNelson Mar 4, 2025
16579ff
Merge branch 'master' into mobile-learn-from-mistakes
ChaseNelson Mar 11, 2025
bd29129
Merge branch 'master' into mobile-learn-from-mistakes
ornicar Mar 12, 2025
f9043fd
also show retrospect feedback in row view upon success
ornicar Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/analyse/css/_layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ body {
margin: $analyse-block-gap 0 0 0;
}

grid-template-rows: auto auto auto minmax(20em, 30vh);
grid-template-rows: auto auto auto minmax(20em, 40vh);
grid-template-areas:
'board'
'controls'
Expand Down
7 changes: 7 additions & 0 deletions ui/analyse/css/_training.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@
flex-flow: column;
justify-content: center;

@include mq-is-col1 {
&.view,
&.win {
flex-flow: row;
}
}

.find,
.fail {
padding-top: 5px;
Expand Down