Skip to content

Conversation

@kraktus
Copy link
Member

@kraktus kraktus commented Feb 28, 2025

@allanjoseph98
Copy link
Member

The alert dialog depends on the warning text. That should be changed as well.

if (line.u === 'lichess' && line.t.toLowerCase().startsWith(`warning, ${myUserId()}`))

@superuser-does
Copy link
Collaborator

In addition to Allan Joseph's comment, please consider if it would now be suitable to make this into a translateable (i18n) string. In terms of text, every word has been carefully considered, so the content can be considered final.

Beyond the usual requirements of adding a translateable string (documented on the Lila wiki), you would also need to ensure that the alert dialog still triggers if it an i18n string.

@kraktus
Copy link
Member Author

kraktus commented Feb 28, 2025

The alert dialog depends on the warning text. That should be changed as well.

if (line.u === 'lichess' && line.t.toLowerCase().startsWith(`warning, ${myUserId()}`))

Thanks! should be fixed. It's difficult to test considering direct challenges do not trigger it.

In addition to Allan Joseph's comment, please consider if it would now be suitable to make this into a translateable (i18n) string. In terms of text, every word has been carefully considered, so the content can be considered final.

Beyond the usual requirements of adding a translateable string (documented on the Lila wiki), you would also need to ensure that the alert dialog still triggers if it an i18n string.

I consider translation a separate feature, and it's outside of the scope of that PR.

@ornicar ornicar merged commit dae27da into lichess-org:master Mar 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants