Skip to content

Don't give draw claims as explanations for imported games #17191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Don't give draw claims as explanations for imported games #17191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/game/src/game.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const moretimeable = (data: GameData): boolean =>
(!!data.correspondence &&
data.correspondence[data.opponent.color] < data.correspondence.increment - 3600));

const imported = (data: GameData): boolean => data.game.source === 'import';
export const imported = (data: GameData): boolean => data.game.source === 'import';

export const replayable = (data: GameData): boolean =>
imported(data) || finished(data) || (aborted(data) && bothPlayersHavePlayed(data));
Expand Down
2 changes: 2 additions & 0 deletions ui/game/src/view/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { Ctrl } from '../interfaces';
import { imported } from '../game';

export function bishopOnColor(expandedFen: string, offset: 0 | 1): boolean {
if (expandedFen.length !== 64) throw new Error('Expanded FEN expected to be 64 characters');
Expand Down Expand Up @@ -73,6 +74,7 @@ export default function status(ctrl: Ctrl): string {
if (insufficientMaterial(d.game.variant.key, d.game.fen))
return `${i18n.site.insufficientMaterial} • ${i18n.site.draw}`;
if (d.game.drawOffers?.some(turn => turn >= d.game.turns)) return i18n.site.drawByMutualAgreement;
if (imported(d)) return i18n.site.draw;
return `${i18n.site.drawClaimed} • ${i18n.site.insufficientMaterial}`;
}
case 'outoftime':
Expand Down