Add explanation for draw claims by insufficient material. #17114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
Mar 8, 2025
| return `${i18n.site.fiftyMovesWithoutProgress} • ${i18n.site.draw}`; | ||
| if (d.game.threefold) return `${i18n.site.threefoldRepetition} • ${i18n.site.draw}`; | ||
| if (insufficientMaterial(d.game.variant.key, d.game.fen)) | ||
| return `${i18n.site.insufficientMaterial} • ${i18n.site.draw}`; |
There was a problem hiding this comment.
it seems like we already have a reusable translation there.
There was a problem hiding this comment.
@ornicar Updated to use it, but having 'Draw claimed' as well avoids confusion (since in the other cases the draw is automatic).
ornicar
reviewed
Mar 8, 2025
ui/game/src/view/status.ts
Outdated
| return `${i18n.site.insufficientMaterial} • ${i18n.site.draw}`; | ||
| if (d.game.drawOffers?.some(turn => turn >= d.game.turns)) return i18n.site.drawByMutualAgreement; | ||
| return i18n.site.draw; | ||
| return i18n.site.drawClaimedByInsufficientMaterial; |
There was a problem hiding this comment.
are we sure the only way to reach this default case is through insufficient material claim?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17088.
This works if the only possibility left for a draw at that point in the code is the claim by insufficient material - should be the case, but not 100% sure. Are there any cases where lichess just says "Draw" (besides what this PR fixes)?