Ublog: disclose sponsored content, affiliate links or commercial advertisement in posts #17121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tors42
reviewed
Mar 9, 2025
9745ab3 to
e1ada6b
Compare
ornicar
reviewed
Mar 9, 2025
| live: Boolean, | ||
| discuss: Option[Boolean], | ||
| sticky: Option[Boolean], | ||
| ads: Option[Boolean], // boo! |
| ), | ||
| form3.checkbox( | ||
| form("ads"), | ||
| "Includes promotion", |
There was a problem hiding this comment.
Maybe "promoted / sponsored content"
It's actually easier and better to filter as a UblogPost.topic, as a db index already exists I would prefer that, except that your extra form toggle allows for a explanatory description, which is probably necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual text labels are WIP, just want to make sure the implementation is right first. I initially thought about just adding a "promotion" tag, but having a separate field in the db will allow for easier filtering later.