resizeable broadcast sides #17280
resizeable broadcast sides #17280
Conversation
|
could also be a solution for tournaments #12995 (or could make the description/chat togglable) |
|
when I first tried it, the default configuration had the game list higher than the page, with the chat fully invisible: |
|
the behavior:
it's a combo of initial reuse of the previous size while still allowing specific broadcasts to differ. this strategy will not always get it right, but is arguably an improvement over global flex & grid constraints |
| key: 'relay-games', | ||
| id: resizeId, | ||
| min: () => 48, | ||
| max: () => 48 * study.chapters.list.size(), |
There was a problem hiding this comment.
silently hardcoding the expected rendered height of a chapter in the list. Just mentioning it.
There was a problem hiding this comment.
every time i look at it, i feel liberated.
|
The chat viewers have migrated below It's not a big deal and only worth fixing if it can be done easily. |
|
after resizing the page from col2 to col1, the chat viewers element is duplicated |
|
after resizing the page from col2 to col1 (which can happen if you rotate your tablet from horizontal to vertical), the slider elements are removed, but the mutation observers remain, and an exception is thrown due to const onDomChange = () => {
const el = divider.previousElementSibling as HTMLElement;
if (el.style.height) return; |
|
good catches. |
|
some of the hooks and indirections in analysis chat are gone. there is one ChatCtrl instance per page boot and chat views are constructed inline with VNodes. round and tournament chat still use the external snabbdom patch, mostly because i don't want to pull on these noodles at the moment. teams patches as well because that javascript has no controller. but i think chat/patch.ts goes away eventually. |
| window.removeEventListener('pointercancel', up); | ||
| const height = parseInt(el.style.height); | ||
| heightStore(o.key, height); | ||
| if (o.id) heightStore(`${o.key}.${o.id}`, height); |
There was a problem hiding this comment.
this is a default/global stored height mechanism. Setting a height somewhere also sets the (default) height of similar elements (for o.key) on other pages (o.id).
I just ran into a user issue due to it:
- open a broadcast with one board, like https://lichess.org/broadcast/fide-womens-world-chess-championship-2025/shanghai--game-5/xeyMoz7D
- try out the boards list resizer, it won't move much in this case, but it sets a new default to 48px as there is one board
- browse to another broadcast with more boards, like https://lichess.org/broadcast/25th-european-womens-chess-championship-2025/round-8/jGnDcYrv
the boards list uses the default value that was set to 48px. It only shows one board and it's not obvious that there are many more.
There was a problem hiding this comment.
maybe only chat size needs a generic category fallback store. good catch and you're right, we should track game picker size individually with no generic fallback, instead always default to min(fit-content, initialHeight / 2).
|
I see liveboard code, but I don't see any liveboard on a broadcast page. |
|
the viewers are now inside a |
| window.removeEventListener('pointercancel', up); | ||
| const height = parseInt(el.style.height); | ||
| heightStore(o.key, height); | ||
| if (o.id) heightStore(`${o.key}.${o.id}`, height); |
ui/analyse/src/view/main.ts
Outdated
| const { study, gamebookPlayView, gaugeOn } = ctx; | ||
|
|
||
| return renderMain(ctx, [ | ||
| console.log(ctrl.opts.chat); |
yeah but it's tough to keep it close to chat because it competes with the resize bar. at least inside the box neat it's clearly part of the element to be resized rather than dangling underneath. could it be integrated with the "Please be nice in the chat" placeholder text? "i.e. viewers so be nice!" since we no longer list individual chat members, we could conceivably just move it somewhere else. like above the game selector. |
|
we could integrate it with the divider control? |
interesting idea |
|
try that one |
|
github no longer lets me push to this PR, I can't tell if they're wrong or if I am. |
Screencast_20250331_163344.webm