Add a reply button in non-game chats. #17214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
Mar 23, 2025
ornicar
reviewed
Mar 23, 2025
ui/chat/src/discussion.ts
Outdated
| const newVal = prefix + chatInput.value; | ||
| chatInput.focus(); | ||
| chatInput.select(); | ||
| if (!document.execCommand('insertText', false, newVal)) { |
There was a problem hiding this comment.
document.execCommand is deprecated
There was a problem hiding this comment.
There are a few alternatives but none are fully ideal (since there's no direct replacement yet for execCommand):
- Just use the code I have inside that if block. The only problem is if the user then does ctrl+z, the '@username' won't be removed.
- Use a third party library (instead of
execCommand) to mimic user input so that the '@username' is included in the browser's ctrl+z stack.
…to reply-button
if you click reply on userA, then userB, then userA again, then userA would be mentioned twice
ornicar
reviewed
Mar 24, 2025
ui/chat/src/discussion.ts
Outdated
| const newVal = prefix + chatInput.value; | ||
| if (!chatInput.value.startsWith(prefix)) chatInput.value = prefix + chatInput.value; | ||
| chatInput.focus(); | ||
| chatInput.select(); |
There was a problem hiding this comment.
not sure what that was for? didn't seem useful to me to have the entire input text selected.
I might be missing something
instead, guess the username from the link in the chat line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12425.