Translate study tour #17216
Merged
Translate study tour #17216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit concerned that these new translations are going to be loaded so many times for nothing. Not only in all studies, but in all broadcasts. And all analysis pages. And, incredibly enough, all swiss and arena tournaments. |
|
I think we should either move these to a new translation file, and lazy-load them. Or, probably better, remove the arena/swiss dependency to the study i18n. |
|
Do you have an example in mind where lazy loading is used ? |
… to study i18n TODO in a couple weeks, remove the now unused `study.downloadAllGames` key. I'm keeping it for now in hope it helps crowdin translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17215
Notes on the wording