live board chat plugin for broadcasts #17226
Conversation
I don't think that's going to fly with the content team |
| this.vm.chapterId = id; | ||
| componentCallbacks(id); | ||
| await this.xhrReload(); | ||
| componentCallbacks(); |
There was a problem hiding this comment.
moving componentCallbacks() before xhrReload() is likely to break something. Is it necessary, why?
There was a problem hiding this comment.
It allows the redraw of the live board to happen at the same time as the main board. otherwise that redraw lags behind a second for some UI flows as it needs onChapterChange. we could insert extra redraw logic to keep the two in sync for all of the various ways in which a chapter can be selected, but i went with MultiRedraw and onChapterChange to cover all the bases.
What could it break?
There was a problem hiding this comment.
Well, componentCallbacks is supposed to tell components about things having changed. It used to do it after things have changed, and now it does it before, so it seemed like it could break something. If said components were reading the data that has changed.
But if it doesn't 🤷
|
This is terrifying like adding extra stories to a building with noodle foundations. I wish there was a simpler way to handle that exotic use case, but can't come up with one. |
|
the problem is that chat views have their own patch function. if we want chat plugins with non-trivial functions such as externally triggered redraw, we need something like MultiRedraw. ultimately, i think chat should just expose a VNode constructor in addition to its controller and get rid of the patching. maybe you could do that if you're itching to refactor things. there's really only two places we have chat right? round & analyse (and all their flavors) |
Good thing they can look at chat instead. |
|
I kid though, I just thought of it from the standpoint of what Dominik was asking for (truly independent of analysis). And we don't flip the multiboard when the big board is toggled either. It's a simple thing to listen for pubsub flip but I'm not at all sure a streamer would want that. |
|
An alternative to MultiRedraw would be a global |
and swiss, arena, simuls and teams |
|
2 is roughly equal to 6. |
| export interface ChatPlugin extends Tab { | ||
| name: string; | ||
| view(): VNode; | ||
| kidSafe?: boolean; // default false |
There was a problem hiding this comment.
curious about why we don't (seem to) load tournament standing plugin in kid mode.
There was a problem hiding this comment.
No reason I can think of. It's probably an unintended effect of disabling the chat for kids.
give option to show live board in place of chat for broadcasts. this feature seems awful redundant for people who can see their multi-boards below, so it could be restricted to contributors to make loepare happy. there are no player bars (those would be redundant as well), the orientation is fixed at white.
also let tournament players hide chat, clean up chat state functions
i imagine you will rightly have concerns about
multiRedraw, hit me up on zulip or discord.