Broadcast group/round/game navigation for nvui #17341
Conversation
| const target = e.target as HTMLSelectElement; | ||
| const selectedOption = target.options[target.selectedIndex]; | ||
| const url = selectedOption.getAttribute('url'); | ||
| if (url) window.location.href = url; |
There was a problem hiding this comment.
instead of a <select> with an event listener, shouldn't this just be a list of plain links in a <menu>?
There was a problem hiding this comment.
In short, I think select is better
Here is what the user hear using NVDA (I put cmd: to show the commands I used)
cmd: Cntl Home, d, d, d (go to the top, scan the landmarks)
main landmark
Current group: combo box Girls collapsed
cmd: Alt arrow up and down (list the possible options in the select group)
combo box expanded
Girls list
Girls 2 of 2
Open 1 of 2
cmd: Enter to choose 'Open
document busy
main landmark
combo box collapsed
Lola Ana broadcast | Open • Round 1 • lichess.dev — Mozilla Firefox
Lola Ana broadcast | Open • Round 1 • lichess.dev busy
button Accessibility: Disable blind mode
main landmark
Current group: combo box Open collapsed
I am not sure, a menu would give such a result
There was a problem hiding this comment.
There a bit of pollution that may be explained by the fact we are using snabdom (the reader starts too soon) ?
Lola Ana broadcast | Open • Round 1 • lichess.dev — Mozilla Firefox
Lola Ana broadcast | Open • Round 1 • lichess.dev busy
button Accessibility: Disable blind mode
main landmark
There was a problem hiding this comment.
Actually, the additional text is only visible in NVDA speech viewer ... not in what you actually hear .. https://www.youtube.com/watch?v=Q6HykFcLOgw (less rushed video waiting for the vocalization to happen)
There was a problem hiding this comment.
I had the confirmation in #17231 that combo box is better than menu
There was a problem hiding this comment.
ok, then could you please refactor the duplicated event listener code?
There was a problem hiding this comment.
Done ... hopefully as you expected
addresses part of #17234
I made some videos to illustrate the same scenario visual vs non visual
In this video, the screen reader keeps reading from the start of the page ... I added an autofocus on the selection that triggers the new page. I think it make the experience better