-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Firi pieceset #17372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firi pieceset #17372
Conversation
|
Recommend run: |
|
Artefacts hopefully resolved: my svg simplifier didn't handle mirror effects properly and produce overlapping nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The layer below the roof has a part on the left side that doesn't connect properly. I can also see this on the website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same not connected line here as for the black piece.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Lila232/lila/blob/master/public/piece/firi/bR.svg
I simplified the rook to a single shape with line accents, can you confirm if that fixes it for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that looks good to me thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually don't notify, but I took the opportunity to minify the pieces
#17488
to help people save a little on the internet
Firi pieceset rook: fix #17372 bug: Redraw as a simpler single shape with line accents
close #16136