Skip to content

Conversation

@jfaure
Copy link

@jfaure jfaure commented Apr 17, 2025

close #16136

@ornicar
Copy link
Collaborator

ornicar commented Apr 17, 2025

something seems to be wrong with the knight? Latest Firefox/Linux

image

I also see an artifact at the top of the queen, or is it intended to be flat like that?

image

@SergioGlorias
Copy link
Member

Recommend run: pnpm piece-css
for the CSS to be correct

@jfaure
Copy link
Author

jfaure commented Apr 17, 2025

Artefacts hopefully resolved: my svg simplifier didn't handle mirror effects properly and produce overlapping nodes

@ornicar ornicar merged commit ae63823 into lichess-org:master Apr 17, 2025
6 checks passed
Copy link

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layer below the roof has a part on the left side that doesn't connect properly. I can also see this on the website.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair I have to zoom in quite closely to see it, here's a screenshot with what I mean.
Lichess screenshot with high zoom

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same not connected line here as for the black piece.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Reading wR.svg in inkscape that node is connected
I can straighten the horizontal lines, maybe that will fix what I assume is a bug with your svg-viewer

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Lila232/lila/blob/master/public/piece/firi/bR.svg

I simplified the rook to a single shape with line accents, can you confirm if that fixes it for you?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks good to me thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually don't notify, but I took the opportunity to minify the pieces
#17488
to help people save a little on the internet

fitztrev added a commit that referenced this pull request May 5, 2025
Firi pieceset rook: fix #17372 bug: Redraw as a simpler single shape with line accents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firi pieceset

6 participants