Skip to content

Cancel a takeback if the opponent (rather than the player) moves #17457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Cancel a takeback if the opponent (rather than the player) moves #17457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bee0df4
Don't cancel a takeback if the player then moves - rather, have the o…
johndoknjas May 3, 2025
c71b0c5
Merge branch 'master' into persist-takeback
johndoknjas May 5, 2025
851bc05
Merge branch 'master' into persist-takeback
ornicar May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/round/src/main/MovePlayer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ final private class MovePlayer(
else
if progress.game.playableByAi then requestFishnet(progress.game, round)
if pov.opponent.isOfferingDraw then round ! RoundBus.Draw(pov.player.id, false)
if pov.player.isProposingTakeback then round ! RoundBus.Takeback(pov.player.id, false)
if pov.opponent.isProposingTakeback then round ! RoundBus.Takeback(pov.player.id, false)
if progress.game.forecastable then
moveOrDrop.move.foreach { move =>
round ! ForecastPlay(move)
Expand Down