Include who did what for takebacks #17468
Conversation
| pov match | ||
| case Pov(game, color) if pov.player.isProposingTakeback => | ||
| messenger.volatile(game, trans.site.takebackPropositionCanceled.txt()) | ||
| messenger.volatile(game, pov.color.name.capitalize + ' ' + trans.site.cancelsTakeback.txt()) |
There was a problem hiding this comment.
i don't think you can glue i18n phrases together like this. you'll need to work the color into the strings as a %s
There was a problem hiding this comment.
@schlawg Good point, updated to use %s.
|
With regard to the i18n strings, it would be preferable if you had a unique string for each colour variation. This is because many languages have cases and I can foresee requests to split them out, based on past experience. So e.g. instead of "%s declines takeback", make it two discrete strings of either "White declines takeback" or "Black declines takeback". |
|
Do we want color or player names there though? I guess if it's always been color |
We would want colours/sides, which is what we do on other strings (e.g. on the profile activity feed) One of the core problems of using names is that many languages have grammatical gender, so translators are forced into using a kludge like he/she, sometimes across multiple words. The homepage feed is one of the few views where that's unavoidable. When it comes to chess games, we can use sides, bypassing the problem altogether. |
Closes #10988.