Skip to content

Conversation

@fitztrev
Copy link
Member

@fitztrev fitztrev commented May 6, 2025

Fixes #17477

@schlawg
Copy link
Contributor

schlawg commented May 6, 2025

Should we even register a wake lock for correspondence games? There is no pressure to immediately show opponent moves.

@fitztrev
Copy link
Member Author

fitztrev commented May 6, 2025

I considered that and figured there might be some people who open up their correspondence games on their phones and think about the move for some amount of time. The screen going dim may be distracting in that situation.

@schlawg
Copy link
Contributor

schlawg commented May 6, 2025

I understand, but I don't think it should be done unless you're playing a real time game. Wake lock is a terrible practice unless there's some important foreground or background activity to sustain, and a correspondence chess game does not qualify. We don't ask for wake lock on puzzles either. It's the same as playing connections or crossword, users might stare at that too but you don't see nytimes disabling screen savers on them.

@fitztrev fitztrev changed the title Release wake lock after 10 mins for correspondence games Disable wake lock in correspondence games May 7, 2025
@schlawg
Copy link
Contributor

schlawg commented May 7, 2025

we could get some pushback from correspondence players who are used to the old behavior (i am one of them), but i think this is the right call. thanks.

@schlawg schlawg merged commit d5b8a03 into lichess-org:master May 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lichess disables my screen saver

2 participants