Skip to content

Conversation

@johndoknjas
Copy link
Contributor

Essentially just undoes e0f9d8e, going back to the original value of 32 @schlawg used in e0f9d8e's parent commit (c3bdbba).

Screen recording showing current behaviour (the tab where I'm moving the scrollbar is for "John1"):

Screen.Recording.2025-05-18.224601.mp4

@schlawg
Copy link
Contributor

schlawg commented May 21, 2025

at one point, a 32px scroll chin made it impossible to scroll to top (to read the first few messages) without having it immediately snap to bottom on certain chats without a sufficient number of messages.

does that still happen? if so, should we try 16 maybe?

@johndoknjas johndoknjas marked this pull request as draft May 24, 2025 19:59
@johndoknjas johndoknjas marked this pull request as ready for review May 25, 2025 03:31
@johndoknjas
Copy link
Contributor Author

@schlawg From my testing, I can't seem to reproduce this issue with 32px, both on my computer and phone.

Also for this PR, the minimum values I've found that make autoscrolling work:

  • 25px on my phone
  • 28px on my computer (29px if the bookmarks bar is hidden, since that makes the chat slightly bigger)

@schlawg
Copy link
Contributor

schlawg commented May 25, 2025

What's your browser, zoom level, and OS?

@johndoknjas
Copy link
Contributor Author

@schlawg On computer Windows 11, 100% zoom, and both chrome and edge. For iphone it's safari, at default zoom.

@schlawg schlawg merged commit 929217e into lichess-org:master May 26, 2025
3 checks passed
@schlawg
Copy link
Contributor

schlawg commented May 26, 2025

got it, thanks. i missed the manually scroll part (and was looking at broadcasts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants