fix:"Clear Board" button no longer changes player to "white to play" (closes #17310) #17574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
May 24, 2025
ui/editor/src/ctrl.ts
Outdated
| modFen[1] = this.turn.split('')[0]; | ||
|
|
||
| clearBoard = (): boolean => this.setFen(EMPTY_FEN); | ||
| return this.setFen(modFen.join(' ')); |
There was a problem hiding this comment.
I think the start position should set white to play. Or it wouldn't quite be the start position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #17310
In the Board Editor, when the "Clear Board" and "Starting Position" button was clicked, the player to move would unexpectedly change to "White to play," even if the user had previously set the player to "Black to play."
Made the necessary changes
Closes #17310