Skip to content

Add empty alt text to feed icons #17587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Add empty alt text to feed icons #17587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b05c43
add empty alt text attributes to feed icons
randompearl-stack May 27, 2025
594acde
add emptyAlt and decorativeImage, use it in iconFlair and the feed em…
ornicar May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/feed/src/main/FeedUi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ final class FeedUi(helpers: Helpers, atomUi: AtomUi)(
)

private def marker(flair: Option[Flair] = none, customClass: Option[String] = none) =
img(
src := flairSrc(flair.getOrElse(Flair("symbols.white-star"))),
iconFlair(flair.getOrElse(Flair("symbols.white-star")))(
cls := customClass.getOrElse(s"daily-feed__update__marker ${flair.nonEmpty.so(" nobg")}")
)
2 changes: 1 addition & 1 deletion modules/ui/src/main/helper/AssetHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ trait AssetHelper:

def flairSrc(flair: Flair): String = staticAssetUrl(s"$flairVersion/flair/img/$flair.webp")

def iconFlair(flair: Flair): Tag = img(cls := "icon-flair", src := flairSrc(flair))
def iconFlair(flair: Flair): Tag = decorativeImg(cls := "icon-flair", src := flairSrc(flair))

def fingerprintTag: EsmList = Esm("bits.fipr")

Expand Down
3 changes: 3 additions & 0 deletions modules/ui/src/main/scalatags.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ trait ScalatagsAttrs:
val enterkeyhint = attr("enterkeyhint")
def attrData(name: String) = attr(s"data-$name")
def aria(key: String) = attr(s"aria-$key")
// https://accessibleweb.com/question-answer/when-should-i-use-a-null-or-empty-alt-tag/
val emptyAlt = alt := ""

object frame:
val scrolling = attr("scrolling")
Expand Down Expand Up @@ -65,6 +67,7 @@ trait ScalatagsSnippets:
val summary = tag("summary")
val abbr = tag("abbr")
val boxTop = div(cls := "box__top")
val decorativeImg = img(emptyAlt)

def rawHtml(html: Html) = raw(html.value)

Expand Down
2 changes: 1 addition & 1 deletion ui/lobby/css/_feed.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
width: 32px;
height: 32px;
padding: 5px;
margin-top: -5px;
transform: translateY(-5px);
margin-inline-start: -42px;
background-color: $c-contours;
border: 3px solid $c-bg-box;
Expand Down