Offer a choice of voices for speech #17678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schlawg May be you want to review this ... |
schlawg
reviewed
Jun 12, 2025
Co-authored-by: Jonathan Gamble <101470903+schlawg@users.noreply.github.com>
|
@schlawg yes you're right about the role. I inherited it from the game setup dialog ... I removed it there too. |
|
Question: do we want a title or is it crystal clear that the dialog offer a change of voice ? |
ornicar
reviewed
Jun 12, 2025
|
I can see tts is also used in ui/dgt ... how do you test that ? |
a12c2ba to
8d03528
Compare
IDK. I would leave it alone. It's a bit of an island, disconnected from the rest of the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17657
Demo: https://youtu.be/2LvgfHKjpDg
It's interesting to see that the browsers also have voices ... it's not all about the system
May be we should put a cogwheel on the speech button to say there is more to it