Timezone: auto select user timezone #17707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72cdec4 to
6f09d6d
Compare
6f09d6d to
0acbd82
Compare
SergioGlorias
commented
Jun 23, 2025
Comment on lines
+2
to
+3
| $('.form3[action="/broadcast/new"] #form3-info_timeZone').each(function (this: HTMLSelectElement) { | ||
| if (!$('.is-invalid').length) this.value = Intl.DateTimeFormat().resolvedOptions().timeZone; |
There was a problem hiding this comment.
It was the best way I found to prevent changes if there is an error or if it's in the edit form.
There was a problem hiding this comment.
if this is specific to the 4 best players, i don't understand an assumption they would all be in the same time zone and i don't understand why we would want to default it to the timezone of the person filling this form.
but if this is what you want to do, lgtm
There was a problem hiding this comment.
(that's a declaration of my ignorance, not a review objection)
ornicar
added a commit
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Become a bit like in the past, but with the possibility to switch