This is a improved version of my past NVUI Retro PR.

addresses - "Learn from your mistakes” feature is not accessible in Blind Mode (NVUI) #17621

ok, i just ask because it's an existing behavior we're changing and people get used to the element structure that exists. it can be jarring even when the new one is an improvement.

each additional heading will lengthen the element summary panel, which blind users do rely on. excessive h4-h6 tags may be discouraged for this reason.

I understand that. I will revert.

"request a computer analysis" seems to have gotten broke somewhere along the many curves of this marathon. there should be an announcement.

There is OMM. Or am I misunderstanding you?

Just tested on lichess.org. You mean on asking, right?

i'm not sure what OMM is. there does not seem to be any confirmation upon selecting "request a computer analysis", so it's not clear whether anything is happening. if that behavior exists on lichess.org as well, apologies for blaming this PR but we still need to fix it.

On my machine. Yes I thought initially you where referring to the acknowledgement of completion.

No I figure out the code that was responsible for sending it prior.

const requestAnalysisButton = (
  ctrl: AnalyseController,
  inProgress: Prop<boolean>,
  notify: (msg: string) => void,
 ): MaybeVNode =>
   ctrl.ongoing || ctrl.synthetic
     ? undefined
     : inProgress()
      ? h('p', 'Server-side analysis in progress')
      : h(

But I can not say that I understand it very well.

ah, that seems important yes. one other little thing is we prefer class based styling over inline style attribute. if you wanted to ensure that labels inside of buttons were always click through (for sighted testing), you could do so in ui/round/css/_nvui.scss with:

label {
  pointer-events: none;
}

i believe that file is included in this page so styles defined there should be available.

Thanks for the expertise. This is the sorta incite I am surly lacking.

I was also including that encase some other assistive technology generated pointer-events.

I do not see a downside, and possible upside.

I am working on the notify.

we're getting closer. once you've addressed the issues above, please try to reduce the number of 'aria-live' directives. we have gone from 4 in the original page to 18 on this one, i don't think they're all necessary - especially the ones on container elements or headings/labels that don't change.

Ok, yes I agree with that.

Thank you sincerely for reviewing my code and helping me to contribute. @schlawg

cool, thanks. i'm going to put this up on a test server so ikrami can look it over without being rushed tomorrow.

thanks for working on it.

i wanted you to be able to continue to work without me constantly dumping updates into your repo, so i started a draft PR based on your work. it seems you may have been waiting for me and i'm done for now, so i've pushed my branch back into your PR.

i think we can merge this assuming yafred and allan sign off.

Yes, I think so. I code like I'm bipolar manic. I am either putting in 13 hour days, or silent.

I was waiting for some test feedback, or something. I can see, and have helped build the interface.

So I do not really know what works and does not, for usability.

This is exactly what caused me to put heading everywhere.

I didn't want to make an assume out of myself.

It would be great to get some feedback from screen reader users.

What works and what doesn't. What would make a better experience, etc.

Due to lack of data, I don't feel like I can make any changes confidently.

Did you get a longer term instance going?

Did you get a longer term instance going?

it's live on https://testy.lichess.dev

today only!

Considering the feature is usable and the only things I don't understand in the code were there before, I'd say let's go for it!

we can wait until allan / thibault has a chance to weigh in. @ikrami1 were you able to check this with JAWS?

@allanjoseph98 it is definitely good enough for me. i was complaining that the board doesn't flip automatically according to the color being reviewed— however, a currently draft PR by the wonderful @yafred is going to add this feature with a shortcut across the entire nvui.

@schlawg it works with jaws, i tested it briefly and anouncements were coming through nicely. usually, whatever works with nvda on the web works with jaws.

We can still do the automatic flip afterwards ... sighted users have both: flip on demand with f and automatic flip when analysing the opponent's mistakes.

there is both manual flip 'f' and automatic flip (review other color mistakes) in this PR.

thanks nicvagn!