Implement reasonably fast and compact BinaryFen #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thanh Le <lenguyenthanh@hotmail.com>
Co-authored-by: Thanh Le <lenguyenthanh@hotmail.com>
lenguyenthanh
approved these changes
Apr 1, 2024
lenguyenthanh
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information stored: Complete FEN (including move numbers, position not necessarily legal, invalid castling rights / ep may be lost) + variant
Relatively compact packing (but still further compressible with entropy coding). Examples:
Main part of the encoding adapted from https://github.com/official-stockfish/nnue-pytorch/blob/master/lib/nnue_training_data_formats.h#L4607.
Move numbers not needed? The default of
0 1is particularly efficient.Quite fast: