Skip to content

Implement pgn.Parser.tags to parse tags #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Implement pgn.Parser.tags to parse tags #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/scala/format/pgn/Parser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ object Parser:
def mainlineWithMetas(pgn: PgnStr): Either[ErrorStr, ParsedMainline[SanWithMetas]] =
pgnMainlineParser.parse(pgn.value, "Cannot parse pgn")

def tags(pgn: PgnStr): Either[ErrorStr, Tags] =
tagsParser.parse(pgn.value, "Cannot parse tags").map(Tags(_))

def moves(strMoves: Iterable[SanStr]): Either[ErrorStr, Sans] =
strMoves.toList.traverse(san).map(Sans(_))

Expand Down Expand Up @@ -236,6 +239,7 @@ object Parser:
private inline def escapePgnTag[A](p: P0[A]): P0[A] =
escape *> P.string("[pgn]").? *> p <* P.string("[/pgn]").? <* escape

private val tagsParser = TagParser.tags.surroundedBy(escape)
private val pgnParser: P0[ParsedPgn] = escapePgnTag(tagsAndMovesParser)

private val pgnMainlineParser: P0[ParsedMainline[SanWithMetas]] =
Expand Down
5 changes: 5 additions & 0 deletions test-kit/src/test/scala/format/pgn/ParserTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@ class ParserTest extends ChessTest:
List(fromProd1, fromProd2, castleCheck1, castleCheck2, fromCrafty, fromWikipedia, fromTcec)
)

test("tags = full.tags"):
val expected = wcc2023.map(PgnStr(_)).traverse(parse).toOption.get.map(_.tags)
val tags = wcc2023.map(PgnStr(_)).traverse(Parser.tags).toOption.get
assertEquals(tags, expected)

def verifyMainline(pgns: List[String]) =
val expected = pgns.map(PgnStr(_)).traverse(parse).toOption.get.map(_.mainline)
val mainline = pgns.map(PgnStr(_)).traverse(parseMainline).toOption.get.map(_.sans)
Expand Down