Improve error messages for Reader.full and friends
#650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ae5055 to
d61e959
Compare
|
instead of |
makes sense, yeah, I was copying error message from: lichess-org/lila#17362 (comment) Will update |
By utilizing the new included rawString in san representation, we can display to users where (with its raw value) it's failed to replay the game.
d61e959 to
043fec8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This include some changes on
pgn.Parserto include the raw value ofSanin it's ADT, which is needed for us to return better error messages. This also matcheschessopslibrary's error messages.here are two examples:
pgn:
pgn: