bump supported versions; fix tests #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0fd217 to
167b7ba
Compare
Our tested support for Go versions is changing to the two latest instead of three latest. This matches what the Go team supports. If lib/pq happens to not work in older versions of Go, you must use an earlier version of lib/pq. Remove tested support for Go 1.9 and 1.10, add Go 1.12. Remove tested support for unsupported Postgres versions (< 9.4). Megacheck was renamed to staticcheck. Fix two issues found by golint.
cbandy
approved these changes
Jul 16, 2019
| - PGVERSION=9.6 | ||
| - PGVERSION=9.5 | ||
| - PGVERSION=9.4 | ||
| - PGVERSION=9.3 |
Contributor
There was a problem hiding this comment.
Should we have a job with PGVERSION=11?
Collaborator
Author
|
I tried that but there's some apt get problem that will require more investigation, so someone can do that in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tested support for Go versions is changing to the two latest instead
of three latest. This matches what the Go team supports. If lib/pq
happens to not work in older versions of Go, you must use an earlier
version of lib/pq.
Remove tested support for Go 1.9 and 1.10, add Go 1.12. Remove tested
support for unsupported Postgres versions (< 9.4).
Megacheck was renamed to staticcheck.
Fix two issues found by golint.