Added display related functions #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMDmi3
requested changes
Jul 25, 2017
SDL2pp/Display.cc
Outdated
| using std::string; | ||
|
|
||
| namespace SDL2pp { | ||
| SDL_Rect GetDisplayBounds(const int displayIndex) { |
Member
There was a problem hiding this comment.
- No need for
constfor copied arguments, ever. - Why not
SDL2pp::Rect?
SDL2pp/Display.hh
Outdated
| /// \param[in] vertical The diagonal DPI of the display | ||
| /// | ||
| //////////////////////////////////////////////////////////// | ||
| DPI(const float diagonal = 0, const float horizontal = 0, const float vertical = 0); |
Member
There was a problem hiding this comment.
Can we just drop this and use braced-init?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes for issue #81 in addition to other Display related functions. Some of them might seem silly to add a wrapper, but I think is a good idea to be able to report errors throwing SDL2pp::Exception so you can catch all of them (or any of the given calls) by using a try/catch block.