fix bug. when gmp version is 6.2.1 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug. when gmp version is bigger than 6.0.0. gmp current version is 6.2.1.
Contributor
|
Hi! Thanks for the PR. I'm not sure your modification makes sense. The point of that test is to check if the version number in the GMP header file is identical to that in the GMP binaries. If they are not, that is is a sign that there is some inconsistency in your system configuration. For example, you might have things set up so that the compiler sees certain header files, but you might not have environment variables set up to see the corresponding library a run time. So...I'm not sure that changing the comparison from != to < makes sense. But perhaps you have an argument to support your proposal...please let me know...I'd be happy to discuss! |
Author
|
Hi Libntl/Ntl,
Thanks for your reply. I think I got some wrong. Thank you very much.
Many Thanks,
Min Wang.
…On Mon, Apr 26, 2021 at 8:30 PM victorshoup ***@***.***> wrote:
Hi! Thanks for the PR. I'm not sure your modification makes sense. The
point of that test is to check if the version number in the GMP header file
is identical to that in the GMP binaries. If they are not, that is is a
sign that there is some inconsistency in your system configuration. For
example, you might have things set up so that the compiler sees certain
header files, but you might not have environment variables set up to see
the corresponding library a run time. So...I'm not sure that changing the
comparison from != to < makes sense. But perhaps you have an argument to
support your proposal...please let me know...I'd be happy to discuss!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5LWVOO4QDSOCTHTA2IZDTKVMH7ANCNFSM43R6XG6A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug. when gmp version is bigger than 6.0.0. gmp current version is 6.2.1.