Added documentation for exported functions in archive_read_disk #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatuska
requested changes
Oct 26, 2021
libarchive/archive_read_disk.3
Outdated
| .It Fn archive_read_disk_set_matching | ||
| Allows the caller to set | ||
| .Tn struct archive | ||
| _*ma to compare each entry during |
There was a problem hiding this comment.
Typo at the beginning of the sencence: _*ma -> *_ma
| "archive_read_disk_descend"); | ||
|
|
||
| if (t->visit_type != TREE_REGULAR || !t->descend) | ||
| if (!archive_read_disk_descend(_a)) |
There was a problem hiding this comment.
I guess this should be archive_read_disk_can_descend as well. Please submit the code changes in an individual pr (separate PR for manual page changes and separate for code changes)
mmatuska
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were previously undocumented functions that were being exported from archive_read_disk.
Added documentation for:
Closes #1496