Skip to content

Conversation

@gleb-kun
Copy link

@gleb-kun gleb-kun commented Mar 7, 2025

Removed hard check assert(sigderlen <= 74 && sigderlen >= 70).
Now, if sigderlen < 70, a warning is displayed instead of an error.

Thanks to Issue #203 participants.

gleb-kun added 4 commits March 8, 2025 01:32
Use sizeof for set sigderlen in form normalized DER signature & hashtype
Need to remove the assert to avoid errors due to signature length changes caused by removing leading zeros, and you want the code to handle signatures of different lengths correctly.
If need to keep the check, but make it less strict and more adaptable, for example by checking only the minimum length. In this case signatures shorter than 70 bytes are allowed and processed accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant