WASI: remove getpid #1103
WASI: remove getpid #1103
Conversation
hartwork
left a comment
There was a problem hiding this comment.
Needs more clarification at #1102 (comment) first
There was a problem hiding this comment.
@Destructor17 is there a chance that you could rebase against latest master with #1104 merged and drop both the -DCMAKE_{EXE,SHARED,MODULE}_LINKER_FLAGS='-lwasi-emulated-getpid' and the -D_WASI_EMULATED_GETPID from the wasi_sdk.yml CI file that I have added there? With some luck (and a small fix for clang-format), CI should be all green after that.
51c50dc to
7fb2c7a
Compare
@hartwork I just rebased to master and applied changes listed above. Hope CI will go green. PS: I'm inspired to see how quickly you extended the CI to cover such niche thing as WASI. Wow! |
Resolves #1102
Alternative 1:
Add a static function named getpid that would simply return 0.
It is somehow similar to
# define getpid GetCurrentProcessIdfor Windows.Alternative 2:
Modify configure/build scripts to add -lwasi-emulated-getpid flag.
Not a good solution in my opinion