fix #303: gdlib.pc: use Requires instead of Libs#537
Merged
Conversation
Member
|
can you rebase ? |
53fc275 to
54e6fcf
Compare
Member
Author
done |
54e6fcf to
5cc7629
Compare
Member
Author
|
@vapier sorry. misunderstood that. it is really done this time. :) |
vapier
requested changes
Nov 27, 2019
vapier
left a comment
Member
There was a problem hiding this comment.
general approach seems fine. still needs to rebase though onto latest master ?
408fe7a to
11c086e
Compare
Member
Author
|
Hi @cmb69 . Could you please spare some time to review this PR? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gdlib.pc: use Requires instead of Libs #303