Templates and other minor changes#1366
Merged
Merged
Conversation
jdumas
reviewed
Nov 29, 2019
| show_labels(false), | ||
| show_texture(false), | ||
| // UINT_MAX sets all bits to 1 so these defaults get applied to all view cores | ||
| show_faces (UINT_MAX), |
Collaborator
There was a problem hiding this comment.
Using ~unsigned(0) would be better to carry the meaning that we are setting all bits.
jdumas
reviewed
Nov 29, 2019
|
|
||
| IGL_INLINE void ImGuiMenu::draw_labels(const igl::opengl::ViewerData &data) | ||
| { | ||
| // Alec: How can we get these to respect (optionally) the depth of the scene? |
Collaborator
There was a problem hiding this comment.
It should be possible to do with ImGui, albeit a bit difficult. See e.g. this discussion. There are other important issues with our current setup for drawing labels (see #1109), so we might be better off re-implementing 3D labels outside of the ImGui framework.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply (change to
[x])