Fix bug in readSTL#1638
Merged
Merged
Conversation
reset the position of the current character in the input
jdumas
requested changes
Nov 2, 2020
jdumas
left a comment
Collaborator
There was a problem hiding this comment.
Good catch! But the seekg should only be inside the two if statements (L53 and L56). In case of binary file you need to continue reading the next 4 bytes for the number of triangles.
Contributor
Author
|
@jdumas Thank you for pointing out! |
jdumas
approved these changes
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reset the position of the current character in the input
Fixes # .
[Describe your changes and what you've already done to test it.]
Commit 1e905cb introduces bug in readSTL.
is_stl_binary(...)is called, the position of the current character forstd::istream inputis accidentally updated because ofinput.read(...). So, I just addinput.seekg(...)to reset the position.Check all that apply (change to
[x])