You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If not, we should keep repmat and merge this helpful fix. Unless I'm misremembering some functions, I think every where we use Eigen::SparseMatrix in libigl we just expose the numeric type (e.g., Eigen::SparseMatrix<T> where T could be double or float). This means we assume/force the storage ordering to be the default (which I believe is column-major). If we merge this, it will be a bit of an outlier in that this function will template on the order, but all(?) other libigl functions will expect default ordering.
As far as i know, replicate() is not supported for sparse matrices (at least it does not appear in the sparse matrix manipulations tutorial https://eigen.tuxfamily.org/dox/group__TutorialSparse.html and my experiments with it did also fail)
I understand that it might be nice to not expose the major type to the outside but it does limit the functionality quite a lot (you can only use RowMajor or ColMajor format). I pledge to expose the major type to the outside to increase the functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Repmat not working for colum major sparse matrices.
Improves performance of repmat
Checklist