Skip to content

recreate pr 301#406

Open
oalders wants to merge 2 commits into
masterfrom
recreate-pr-301
Open

recreate pr 301#406
oalders wants to merge 2 commits into
masterfrom
recreate-pr-301

Conversation

@oalders

@oalders oalders commented Jan 21, 2022

Copy link
Copy Markdown
Member
  • Issue 186: use localhost instead of IPv4 address
  • Update Changes

Fixes #186

@codecov

codecov Bot commented Jan 21, 2022

Copy link
Copy Markdown

Codecov Report

Base: 61.32% // Head: 61.32% // No change to project coverage 👍

Coverage data is based on head (88c66e8) compared to base (88c66e8).
Patch has no changes to coverable lines.

❗ Current head 88c66e8 differs from pull request most recent head 33363b4. Consider uploading reports for the commit 33363b4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #406   +/-   ##
=======================================
  Coverage   61.32%   61.32%           
=======================================
  Files          14       14           
  Lines        1386     1386           
  Branches      393      393           
=======================================
  Hits          850      850           
  Misses        354      354           
  Partials      182      182           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oalders

oalders commented Jan 24, 2022

Copy link
Copy Markdown
Member Author

This breaks testing on macOS and Windows.

simbabque
simbabque previously approved these changes Jun 21, 2022
@simbabque

Copy link
Copy Markdown
Contributor

It looks alright. Can we rerun the test suite?

@oalders

oalders commented Jun 21, 2022

Copy link
Copy Markdown
Member Author

I just rebased and force-pushed. That should start a new build.

@oalders

oalders commented Jun 23, 2022

Copy link
Copy Markdown
Member Author

It looks like it's t/local/http.t that is causing the problems.

@simbabque

Copy link
Copy Markdown
Contributor

I suspect it's the $base->host that is not matching localhost, but I haven't tested it yet.

@simbabque simbabque closed this Apr 27, 2023
@simbabque simbabque reopened this Apr 27, 2023
@simbabque

Copy link
Copy Markdown
Contributor

It works on my machine. I haven't figured out yet why it fails in the GH action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run tests against localhost instead of hostname [rt.cpan.org #94959]

2 participants