Skip to content

Conversation

@heli-os
Copy link
Contributor

@heli-os heli-os commented Jul 4, 2022

Motivation:

  • Found some typos when running the tests.
  • Wanted to improve the example.

Modifications:

  • correct typo in some files
    • Test files
    • Released Method's Parameter name
    • PR Template, typo is being applied in this conversation 🙂
  • modifications to unify code style
    • In the test code, sut is using private but it's not private in JpaCriteriaQueryBuilderTest
    • Remove one trailing commas
  • change example code to not use platform type
    Platform type requires unnecessary boilerplate(!!, let trick, ...)
    I think it should be best practice because many people can copy & paste that. Please review.

Result:

There is no change that users can feel.

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2022

CLA assistant check
All committers have signed the CLA.

@heli-os heli-os changed the title Fix/typo and text style Correct typo and Unify code style Jul 4, 2022
Copy link
Member

@shouwn shouwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help!

@huisam huisam merged commit d6d24e5 into line:main Jul 6, 2022
@heli-os heli-os deleted the fix/typo-and-text-style branch July 6, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants