Make ColorSpace marker types non-instantiable#215
Open
leonardohn wants to merge 1 commit into
Open
Conversation
The ColorSpace trait is supposed to be implemented by marker types that exist only at the type level, i.e., `let _ = Srgb;` has no meaningful use and should not be allowed by the compiler. This commit modifies all types that implement ColorSpace to use empty enums instead, so they cannot be instantiated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ColorSpace trait is supposed to be implemented by marker types that exist only at the type level, i.e.,
let _ = Srgb;has no meaningful use and should not be allowed by the compiler. This commit modifies all types that implement ColorSpace to use empty enums instead, so they cannot be instantiated.