Skip to content

Add DynamicColor::new constructor for convenience#219

Merged
tomcur merged 3 commits into
linebender:mainfrom
tomcur:push-ktqoxqpykmku
May 9, 2026
Merged

Add DynamicColor::new constructor for convenience#219
tomcur merged 3 commits into
linebender:mainfrom
tomcur:push-ktqoxqpykmku

Conversation

@tomcur

@tomcur tomcur commented May 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@tomcur tomcur force-pushed the push-ktqoxqpykmku branch from 7f5ee26 to 940dca2 Compare May 6, 2026 13:02
@waywardmonkeys

waywardmonkeys commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Maybe use this where a DynamicColor is constructed in parsing?

@tomcur

tomcur commented May 6, 2026

Copy link
Copy Markdown
Member Author

Ah, I now added it to the from_alpha_color constructor (missed it, but it's just below!). The parser uses its own color_from_components which builds the Missing flags

@tomcur tomcur force-pushed the push-ktqoxqpykmku branch from 1d6983e to 086ed4c Compare May 9, 2026 09:06
@tomcur tomcur added this pull request to the merge queue May 9, 2026
Merged via the queue into linebender:main with commit 36ff492 May 9, 2026
16 checks passed
@tomcur tomcur deleted the push-ktqoxqpykmku branch May 9, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomcur @waywardmonkeys @DJMcNab