test(destination): Replace sleeps with RetryFor in ClusterStoreTest#14250
Merged
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
alpeb
reviewed
Jul 17, 2025
Comment on lines
+97
to
+103
| cs.RLock() | ||
| actualLen := len(cs.store) | ||
| cs.RUnlock() | ||
|
|
||
| if actualLen != len(tt.expectedClusters) { | ||
| return fmt.Errorf("expected to see %d cache entries, got: %d", len(tt.expectedClusters), actualLen) | ||
| } |
alpeb
approved these changes
Jul 17, 2025
Member
|
and likewise, thank you @alpeb for taking the time to review and apply changes to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cluster store tests use a
time.Sleepto wait for events to propagate through the kubernetes API. However, this is flaky and unreliable and can cause test failures when event propagation is slow.Replace the 50ms sleep with a RetryFor which checks for the desired state once per second for up to 30 seconds.