fix(values): make Controller values untyped#14205
Merged
Merged
Conversation
adleong
reviewed
Jul 3, 2025
adleong
left a comment
Member
There was a problem hiding this comment.
Thanks @wim-de-groot!
Using a percentage in values_test.go makes sense so that we get test coverage. For the actual maxUnavailable value in values.yaml, let's keep this at the most conservative values of 1.
f510820 to
3c98469
Compare
Contributor
Author
|
Thanks @adleong for the feedback, I added an other parsing test. I think that should do the trick. |
Make Controller value untyped because its consistent with the field DeploymentStrategy and it allows for % based PDB. Refs: linkerd#13243 Signed-off-by: Wim de Groot <34519486+wim-de-groot@users.noreply.github.com>
Contributor
Author
|
@adleong any update on when this can be reviewed? |
Member
|
hi @wim-de-groot, Alex is currently out of office. she'll be able to review this once she's back, thanks for your patience. ❤️ |
adleong
approved these changes
Jul 24, 2025
Member
|
@wim-de-groot thanks for all the patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Controller value untyped because its consistent with the field DeploymentStrategy and it allows for % based PDB.
Fixes: #13243