fix(destination): fix workload subscribers metric#14683
Merged
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
olix0r
reviewed
Nov 5, 2025
Signed-off-by: Alex Leong <alex@buoyant.io>
olix0r
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The destination controller has a gauge metric called
workload_subscriberswhich tracks the number of subscribers to an endpoint profile. However, since we have dropped all labels from this metric due to high cardinality, we are now re-using the same gauge for all ip:port publishers. This means that each time we set the gauge value, it overrides the previous value and only tracks the number of subscribers to the most recently subscribed ip:port combination.We move this logic up so that the
workload_subscribersgauge instead tracks the total number of subscribers across all ip:port publishers.