2856 refactor dataframe helper out of compliance test helper#2951
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2951 +/- ##
==========================================
+ Coverage 80.30% 84.00% +3.69%
==========================================
Files 147 147
Lines 15988 15990 +2
Branches 3234 3234
==========================================
+ Hits 12839 13432 +593
+ Misses 2478 1842 -636
- Partials 671 716 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amc-corey-cox
left a comment
There was a problem hiding this comment.
This looks good. I mentioned something about the skip list but I don't think it needs to hold up the merge but do please get back to me with a response on that.
| "test_cardinality-ClassNameEQ_C__SlotNameEQ_sSPACE1__TypeNameEQ_tSPACE1", | ||
| "test_cardinality-ClassNameEQ_C__SlotNameEQ_1s__TypeNameEQ_T1", | ||
| "test_cardinality-ClassNameEQ_C__SlotNameEQ_1s__TypeNameEQ_T1", | ||
| ] |
There was a problem hiding this comment.
Are we skipping these because they are not implemented or unnecessary? Will we be dealing with these later somehow?
There was a problem hiding this comment.
I think those tests fail because I need to improve slot name handling in edge cases, so not addressed in these PRs, but I may have a fix in work-in-progress code.
I'm moving toward tracking the skip list here rather than touching many individual test/test_compliance/*.py files just to skip or not skip individual tests while a generator is under development. Very open to suggestions or questions on this approach.
Most of the other tests that are turned off in this PR that deal with inlining will be re-enabled by the end of these PRs, expanding the functionality overall.
This is part of a group of PRs that implement multiple generation targets
in the Pandera dataframe generator. #2975
This is to enable PolaRS support #2856.
(see the description of 2856 for the full list of PRs)
The main tests to re-run on the specific functionality are:
uv run pytest -s -vv --cli-log-level=INFO -m panderagen tests/test_compliance/
This PR specifically:
check_data_pandera()function mostly verbatim out of helper.py in the test_compliance suite.Note that the logic in
check_data_pandera()will be improved in a future PR in this series once the PolaRS schema generator is enabled. A few additional inlining tests will also be skipped until that time.