Skip to content

Fixes issue #3235: Summary generator prefixes enums in ranges with "Unknown_"#3236

Merged
kevinschaper merged 2 commits into
linkml:mainfrom
sveinugu:3235-summary-generator-enum-unknown
Apr 1, 2026
Merged

Fixes issue #3235: Summary generator prefixes enums in ranges with "Unknown_"#3236
kevinschaper merged 2 commits into
linkml:mainfrom
sveinugu:3235-summary-generator-enum-unknown

Conversation

@sveinugu

@sveinugu sveinugu commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Fixes issue #3235.

@codecov

codecov Bot commented Mar 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.89%. Comparing base (8de775c) to head (d42fa74).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/linkml/src/linkml/generators/summarygen.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
+ Coverage   80.27%   83.89%   +3.62%     
==========================================
  Files         150      150              
  Lines       17570    17571       +1     
  Branches     3664     3664              
==========================================
+ Hits        14104    14741     +637     
+ Misses       2674     1991     -683     
- Partials      792      839      +47     
Flag Coverage Δ
linkml 80.26% <0.00%> (-0.01%) ⬇️
runtime 80.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matentzn matentzn linked an issue Mar 4, 2026 that may be closed by this pull request
@matentzn matentzn requested a review from kevinschaper March 26, 2026 18:24

@kevinschaper kevinschaper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sveinugu, and sorry for taking so long to get to this PR.

I think we could handle this by supporting enums in class_or_type_name(), but bringing this PR in now doesn't prevent us from doing that in the future.

Much appreciated!

@kevinschaper kevinschaper merged commit ba558bf into linkml:main Apr 1, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Summary generator prefixes enums in ranges with "Unknown_"

3 participants