🩹 Fix typo in Public Ip Widget endpoint definition for ip-api provider#1869
Merged
lissy93 merged 1 commit intoJul 19, 2025
Merged
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lissy93
approved these changes
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: Bugfix
Overview
First of all, thanks for the nice dashboard ❤️
I'm running
3.1.0via docker in my home lab and found that thePublic IpWidget does not work with theip-apiprovider.After some looking around, I found endpoint lookup uses
ipapiin the comparison instead ofip-api, which is used in processData and in the docs.This causes either the data fetching to be incorrect (for me
ipapi.cofails to fetch 🤷♀️) or the data processing.Before
Widget with provider
ip-adrWidget with provider
ipadrAfter
Widget with provider
ip-adrCode Quality Checklist (Please complete)